Replace old @fluent/react examples with a single new one #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Gregoor As someone who has built a large app using |
Gregoor
reviewed
Apr 6, 2020
Contributor
Gregoor
left a comment
Gregoor
left a comment
There was a problem hiding this comment.
Love it! I think it does exactly what you set out to do and would've made me productive with Fluent even faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old examples showecased a number of different approaches to integrating
@fluent/reactinto React apps. Each example was also focused on just one aspect of the integration. For instance, there was a separate example for simple translations, a different one for localizing elements with attributes, another for localizing markup via overlays, yet another for using thewithLocalizationHOC, etc.This approach meant that it was a lot of work to keep examples up to date with changes to React and
@fluent/react.In this PR, I removed all old examples and replaced them with a single React app which uses most of
@fluent/react's features. It doesn't demonstrate all possible integrations, but I hope it's good enough to be useful, and small enough in scope to be maintained.Fixes #424.