Support astral Unicode characters in TextElements and StringLiteral #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pike
approved these changes
Oct 12, 2018
Contributor
Pike
left a comment
Pike
left a comment
There was a problem hiding this comment.
Just a nit.
I wish we had something better to link to than someone's blog for documentation on unicode regexp, but haven't found anything competitive on MDN.
spec/fluent.ebnf
Outdated
| /* Any Unicode character from BMP excluding C0 control characters, space, | ||
| * surrogate blocks and non-characters (U+FFFE, U+FFFF). | ||
| * Cf. https://www.w3.org/TR/REC-xml/#NT-Char | ||
| * TODO Add characters from other planes: U+10000 to U+10FFFF. |
Contributor
Author
|
There's the ES spec: https://ecma-international.org/ecma-262/6.0/#sec-literals-string-literals but it's a bit cryptic. |
Contributor
Author
|
Thanks for the review, I'll merge this once I publish 0.7. |
zbraniecki
pushed a commit
to zbraniecki/fluent
that referenced
this pull request
Oct 22, 2018
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #174.