Change line endings in comments to line_end #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /.*/ regex doesn't match any of the line endings recognized by the JS RegExp engine, i.e. \n, \r, \u2028, \u2029. These are different from the line endings supported by the rest of the Fluent Syntax. This change unifies the line endings in all grammar productions.
Pike
approved these changes
Nov 18, 2018
Contributor
Pike
left a comment
Pike
left a comment
There was a problem hiding this comment.
We should do the same for comments and junk. Not sure if they should share a rest_of_line production, but they should implement the same solution for the problem.
Not opinionated on which of the two impls to use.
Contributor
Author
I think they are different and they shouldn't share the same solution. Line endings in Comments are normalized to LF. Line endings in Junk are unchanged, as per #184. |
This was referenced Nov 19, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/.*/regex doesn't match any of the line endings recognized by the JS RegExp engine, i.e.\n,\r,\u2028,\u2029. These are different from the line endings supported by the rest of the Fluent Syntax. This change unifies the line endings in all grammar productions.