Fix for panic when removing RenetServer or RenetClient resource#8
Fix for panic when removing RenetServer or RenetClient resource#8Shatur merged 5 commits intosimgine:masterfrom paul-hansen:fix-reload-resource-not-exist
Conversation
There was a problem hiding this comment.
Thanks! Could you try to put these systems to CoreSet::StateTransition instead and apply .before(run_enter_schedule::<S>)? This change will make the intent obvious and comments won't be necessary.
I also think that you could call .in_base_set on a tuple to avoid calling it on each system.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 96.69% 96.73% +0.03%
==========================================
Files 13 13
Lines 969 979 +10
==========================================
+ Hits 937 947 +10
Misses 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Yeah that's much clearer. I hadn't noticed CoreSet::StateTransitions before, learned some things, thanks! |
|
Test fails, I will take a look. |
|
Hmm also looking, just running |
|
Looks like it happens sometimes. |
|
Ah yeah I did get it after a few more tries. |
We no longer have one frame delay.
|
Fixed it. It turns out that in tests we had two |
|
Nice! |
Fixes #7