Patched Datastream#stream to work with controlGroup E (fixes #88) #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Review please @jcoyne @jeremyf @barmintor |
lib/rubydora/datastream.rb
Outdated
Contributor
There was a problem hiding this comment.
entity_size is a more idiomatic name.
Contributor
There was a problem hiding this comment.
or entry_size_for implying that there is a parameter?
Contributor
|
I don't have enough experience with Rubydora regarding this. From the Hydra Committers call on 2014-09-15
|
The `stream` method relied on the `dsSize` attribute of the datastream to report the content length; however, a Fedora 3 repo always reports `dsSize` 0 for external datastreams. This patch permist the existing method to work with external datastreams while preserving the original behavior for other type (managed and inline). Since Hydra::Controller::DownloadBehavior relies on this method, the patch allows that module to function on external datastreams without modification.
Contributor
Author
jeremyf
added a commit
that referenced
this pull request
Sep 15, 2014
Patched Datastream#stream to work with controlGroup E (fixes #88)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.