Improve Caching and Replay Example #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
rht
reviewed
Feb 25, 2024
examples/caching_and_replay/model.py
Outdated
|
|
||
| self.schedule = mesa.time.RandomActivation(self) | ||
| self.grid = mesa.space.SingleGrid(width, height, torus=True) | ||
| self.grid = mesa.space.SingleGrid(height, width, torus=True) |
Contributor
Author
There was a problem hiding this comment.
I tried to follow the benchmark schelling model, and in that height is first.
But on checking mesa.space.SingleGrid width is indeed first. The change needs to be done in the benchmark code also. I have submitted a PR previously for benchmark, I'll make the change in all the schelling models in this repo and the maine mesa repo
rht
reviewed
Feb 25, 2024
examples/caching_and_replay/model.py
Outdated
| # its contents. (coord_iter) | ||
| for cell in self.grid.coord_iter(): | ||
| x, y = cell[1] | ||
| for _cont, pos in self.grid.coord_iter(): |
Contributor
There was a problem hiding this comment.
Unused loop variable should be named just _.
rht
reviewed
Feb 25, 2024
examples/caching_and_replay/run.py
Outdated
| Display an informational text about caching and the status of the cache file (existing versus not existing) | ||
| """ | ||
| cache_file = Path("./my_cache_file_path.cache") | ||
| cache_file = Path("./" + model_params["cache_file_path"]) |
Contributor
There was a problem hiding this comment.
The ./ should be part of model_params["cache_file_path"], given that it is a path instead of a filename.
Contributor
|
Other than the comments, everything else LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
Discussion Topic:
While it is possible to now replay models, I feel there are still some things that can be improved,