Drop Python 3.11, require Python 3.12+ and update to modern type parameter syntax #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit drops Python 3.11 support and require Python 3.12+ following SPEC 0. See the Python 3.12 release notes: https://docs.python.org/3/whatsnew/3.12.html The Mesa 3.3.x release series will keep supporting Python 3.11.
With the minimum Python version now at 3.12, we can use the modern type parameter syntax (PEP 695) instead of the legacy Generic[T] pattern. This change improves code readability and aligns with current Python typing best practices. Changes: - CellCollection: Convert from Generic[T] to type parameter syntax with Cell bound - DiscreteSpace: Convert from Generic[T] to type parameter syntax with Cell bound - Grid: Remove redundant Generic[T] inheritance (already inherits from DiscreteSpace[T]) - accept_tuple_argument: Convert function type variable to use type parameter syntax - Remove unused Generic imports from typing module These changes are purely syntactic modernizations with no functional impact. The type parameter syntax is more concise and better integrated with Python's type system. Fixes ruff UP046 and UP047 violations.
The Grid class inherits from DiscreteSpace[T], which already provides generic type support. The additional Generic[T] inheritance is redundant and triggers a ruff UP046 violation. Changes: - Remove Generic[T] from Grid class inheritance - Remove unused Generic import from typing module - Keep TypeVar T definition as it's still needed for DiscreteSpace[T] parameterization Fixes ruff UP046 violation in grid.py.
|
Performance benchmarks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Mesa to require Python 3.12 as the minimum version and adopts the new PEP 695 type parameter syntax introduced in Python 3.12.
Python 3.11 support is dropped following SPEC 0. The Mesa 3.3.x release series will keep supporting Python 3.11.
Key changes:
pyproject.toml, documentation, and pre-commit configurationGeneric[T]+TypeVarsyntax with modern type parameter syntax (class MyClass[T: Bound]:)Genericinheritance where classes already inherit from generic base classesDiscreteSpace,CellCollection,Grid, and decorator type hintsPlease review. I would like to fast-forward merge this myself.