Skip to content

Conversation

@charlieroecss
Copy link
Contributor

I noticed that in model.py the DataCollector wasn't doing anything with the data, so I updated it to create data files at certain step counts during the run.

I noticed that in model.py the DataCollector wasn't doing anything with the data, so I updated it to create data files at certain step counts during the run.
@coveralls
Copy link

coveralls commented Dec 7, 2017

Coverage Status

Coverage remained the same at 82.911% when pulling bc074be on cgit2017:bank_reserves_example_datacollection_update into 67f14ab on projectmesa:master.

@TaylorMutch
Copy link
Contributor

@cgit2017 Aside, I am now a bit confused, and possibly should have addressed this in the first PR. In the bank_reserves example, there are two files that are nearly identical. batch_run.py and bank_reserves/model.py. Is there a need to have both? There is also a bunch of duplicated code there.

@TaylorMutch
Copy link
Contributor

TaylorMutch commented Dec 7, 2017

@cgit2017 I think it makes sense to want to output data at intervals within a batch run, but having the model itself contain the logic for outputs doesn't seem like the right approach to me. However, your change might be better suited being applied more generally to the BatchRunner class in some way!

@charlieroecss
Copy link
Contributor Author

@TaylorMutch I think that's a better idea. I guess you'll reject the pull request? And I can start working on that idea for the BatchRunner.

@TaylorMutch
Copy link
Contributor

TaylorMutch commented Dec 7, 2017

I'll go ahead and close it. Also, I would suggest the following when developing mesa:

  • Create a Python virtual environment. This will help prevent issues with global Python packages being pulled into your development code. You can create a virtual environment as follows:
# You can substitute 'mesa-env' for whatever name you want to call your virtual environment
> python -m mesa-env 

# Now 'activate' your virtual environment
# On Windows, substitute 'Scripts' for 'bin'
> mesa-env/bin/activate

# Your terminal should now start with the name of your virtual environment
(mesa-env) > 

I hope this helps, and always feel free to send questions to the Mesa Google Group!

@TaylorMutch TaylorMutch closed this Dec 7, 2017
@jackiekazil jackiekazil added this to the Unknown milestone milestone Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants