Skip to content

Conversation

@onefork
Copy link

@onefork onefork commented Jun 2, 2020

Checklist

  • The code has been run through pretty yarn run pretty
  • The tests pass on CircleCI
  • You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • The PR Template has been filled out (see below)
  • Had a beer/coffee because you are awesome

What?

Fixes #406
Fixes #437
Fixes #533

Why?

The loading order of modules is bundler dependent. This module currently compiles to a broken script e.g. under certain Webpack config.

How?

Use internal module pattern to ensure loading order.

Feel good image:

(Add your own one below :])

LOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error thrown when running demo project demo project does not run

2 participants