Add support for https catalog repo #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because component-argocd can't use Vault references directly (due to needing to be able to be synced to setup the Vault integration during cluster bootstrap), we simply provide a parameter which contains the name of an externally managed secret in the `syn` namespace. This secret must have keys `username` and `password` which will be configured as the credentials for the cluster catalog if the catalog URL starts with `https://`.
Rendered from template version: main (ff9d5a8)
simu
force-pushed
the
feat/https-catalog
branch
from
e25e52a to
e4d3111
Compare
DebakelOrakel
approved these changes
Dec 17, 2024
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because component-argocd can't use Vault references directly (due to needing to be able to be synced to setup the Vault integration during cluster bootstrap), we simply provide a parameter which contains the name of an externally managed secret in the
synnamespace.This secret must have keys
usernameandpasswordwhich will be configured as the credentials for the cluster catalog if the catalog URL starts withhttps://.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.