Add best practices guide for using kustomizations in Commodore components #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
corvus-ch
suggested changes
Oct 10, 2022
Contributor
corvus-ch
left a comment
corvus-ch
left a comment
There was a problem hiding this comment.
Please clarify the use of \ in the Kustomize arguments.
docs/modules/ROOT/pages/explanations/commodore-components/kustomizations.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/explanations/commodore-components/kustomizations.adoc
Outdated
Show resolved
Hide resolved
simu
force-pushed
the
explanation/kustomization-best-practices
branch
3 times, most recently
from
7ec2361 to
54f1770
Compare
simu
force-pushed
the
explanation/kustomization-best-practices
branch
from
54f1770 to
26cdd56
Compare
bastjan
reviewed
Oct 10, 2022
docs/modules/ROOT/pages/explanations/commodore-components/kustomizations.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/explanations/commodore-components/kustomizations.adoc
Show resolved
Hide resolved
Co-authored-by: Sebastian Widmer <sebastian.widmer@vshn.net>
bastjan
approved these changes
Oct 10, 2022
simu
added a commit
to appuio/component-openshift4-slos
that referenced
this pull request
Oct 10, 2022
2 tasks
simu
added a commit
to appuio/component-openshift4-slos
that referenced
this pull request
Oct 10, 2022
corvus-ch
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also projectsyn/commodore#646
Checklist