Skip to content

Commit f36dfeb

Browse files
authored
fix: make sure errors get logged to stderr (#34)
1 parent dd85003 commit f36dfeb

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

src/cli/cli.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ async function cli(cli_args: string[]) {
2525
return tap(report, params)
2626
}
2727
if (params.reporter === 'json') {
28-
// oxlint-disable-next-line no-null
29-
return console.log(JSON.stringify(report))
28+
let log = JSON.stringify(report)
29+
return report.report.ok ? console.log(log) : console.error(log)
3030
}
3131
return pretty(report, params)
3232
}

src/cli/reporters/pretty.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,9 @@ export function print_lines({ report, context }: Report, params: CliArguments, {
109109
}
110110

111111
export function print(report: Report, params: CliArguments): void {
112+
let logger = report.report.ok ? console.log : console.error
113+
112114
for (let line of print_lines(report, params, { styleText, print_width: process.stdout.columns })) {
113-
console.log(line)
115+
logger(line)
114116
}
115117
}

src/cli/reporters/tap.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function ok(n: number, description?: string) {
1414
}
1515

1616
function not_ok(n: number, description?: string) {
17-
console.log(`not ok ${n} ${description ? `- ${description}` : ''}`)
17+
console.error(`not ok ${n} ${description ? `- ${description}` : ''}`)
1818
}
1919

2020
function meta(data: Record<string | number, string | number>) {

0 commit comments

Comments
 (0)