Skip to content

call toLowerCase() less often #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2024
Merged

call toLowerCase() less often #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ function is_uppercase(str) {
return /[A-Z]/.test(str)
}

/** @param {string} str */
function lowercase(str) {
if (is_uppercase(str)) {
return str.toLowerCase()
}
return str
}

/**
* @param {import('css-tree').CssNode} node
* @param {string} css
Expand Down Expand Up @@ -130,16 +138,15 @@ function print_simple_selector(node, css) {
}
case 'PseudoElementSelector': {
buffer += COLON + COLON
buffer += is_uppercase(child.name) ? child.name.toLowerCase() : child.name
buffer += lowercase(child.name)
break
}
case 'PseudoClassSelector': {
buffer += COLON

// Special case for `:before` and `:after` which were used in CSS2 and are usually minified
// as `:before` and `:after`, but we want to keep them as `::before` and `::after`
let name = child.name
let pseudo = is_uppercase(name) ? name.toLowerCase() : name
let pseudo = lowercase(child.name)

if (pseudo === 'before' || pseudo === 'after') {
buffer += COLON
Expand Down Expand Up @@ -294,10 +301,9 @@ function print_block(node, css, indent_level) {
*/
function print_atrule(node, css, indent_level) {
let buffer = indent(indent_level) + '@'
let name = node.name
let prelude = node.prelude
let block = node.block
buffer += is_uppercase(name) ? name.toLowerCase() : name
buffer += lowercase(node.name)

// @font-face has no prelude
if (prelude !== null) {
Expand Down Expand Up @@ -345,9 +351,7 @@ function print_declaration(node, css, indent_level) {

// Lowercase the property, unless it's a custom property (starts with --)
if (!(property.charCodeAt(0) === 45 && property.charCodeAt(1) === 45)) { // 45 == '-'
if (is_uppercase(property)) {
property = property.toLowerCase()
}
property = lowercase(property)
}

let value = print_value(node.value, css)
Expand Down Expand Up @@ -436,10 +440,7 @@ function print_operator(node) {

/** @param {import('css-tree').Dimension} node */
function print_dimension(node) {
let unit = node.unit
let buffer = node.value
buffer += is_uppercase(unit) ? unit.toLowerCase() : unit;
return buffer
return node.value + lowercase(node.unit)
}

/**
Expand All @@ -459,12 +460,7 @@ function print_value(node, css) {
* @param {string} css
*/
function print_function(node, css) {
let name = node.name
let buffer = name

if (is_uppercase(name)) {
buffer = name.toLowerCase()
}
let buffer = lowercase(node.name)

buffer += '('
buffer += print_list(node.children, css)
Expand Down