Added validation and enum for operational mode. #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
serve-validation
branch
from
0a54998 to
24b8eec
Compare
ArthurSens
reviewed
Oct 14, 2024
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
Reading "default" as an operational mode, I have no idea what is the behavior 😬. Would it make sense to name it similarly to the others (the actual behavior)?
Member
Author
|
Do you mean in main.go? Fair, will add |
bwplotka
force-pushed
the
serve-validation
branch
2 times, most recently
from
35a9cb8 to
fbab3c5
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
serve-validation
branch
from
fbab3c5 to
8bda426
Compare
Member
Author
|
Done @ArthurSens |
ArthurSens
approved these changes
Oct 14, 2024
prateeknayak
pushed a commit
to prateeknayak/avalanche
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just cleanup and more reliability (feedback when misconfigured).