Cut 0.6.0; Reverted default values for metric types, let's not break compatibility there #101
Conversation
jmichalek132
left a comment
jmichalek132
left a comment
There was a problem hiding this comment.
Small nit since you don't want to break combability with this release do we also want to revert the change from this pr #99?
LGTM otherwise.
With any release we ideally don't break compatibility, but we want and can break compatibility (we are 0.x version) if necessary. I believe metric-interval is worth it, but I reverted metric types as it's more surprising and unwanted potentially. WDYT? @jmichalek132 |
Yeah I think this is closer to behavior people would want, and it's not as breaking as changing the name of the flag. Okay with me. |
No description provided.