Refactor indices collector #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Adams <github@joeadams.io>
sysadmind
force-pushed
the
refactor-indices
branch
from
9efe49d to
b6022a1
Compare
Signed-off-by: Joe Adams <github@joeadams.io>
SuperQ
reviewed
Mar 6, 2025
SuperQ
approved these changes
Mar 6, 2025
Contributor
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Minor nit, otherwise LGTM.
Signed-off-by: Joe Adams <github@joeadams.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will refactor to use the Collector interface in a future change