Skip to content

add ingest total metrics #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add ingest total metrics #617

wants to merge 6 commits into from

Conversation

@zengxilong
Copy link

It's PR for #572

@zengxilong
add ingest total metrics
0926b4d 
Signed-off-by: zengxilong <zengxilonglh@gmail.com>
@zengxilong zengxilong force-pushed the feature/add_ingest_metrics branch from e055d49 to 0926b4d Compare August 28, 2022 09:37
@zengxilong
Copy link
Author

@sysadmind Could you please review this PR ? Thanks.

sysadmind
sysadmind requested changes Aug 29, 2022
View reviewed changes
@zengxilong zengxilong force-pushed the feature/add_ingest_metrics branch 2 times, most recently from 454ad9d to 1f54b11 Compare August 29, 2022 16:53
@zengxilong
fix ingest metrics type and add readme
66c5e89 
Signed-off-by: zengxilong <zengxilonglh@gmail.com>
@zengxilong zengxilong force-pushed the feature/add_ingest_metrics branch from 1f54b11 to 66c5e89 Compare August 29, 2022 16:54
@zengxilong zengxilong requested a review from sysadmind August 29, 2022 16:55
@zengxilong
Copy link
Author

PTAL @sysadmind

@rgarcia89
Copy link

Where are we with this PR? I would be interested to get to know how much ingest is being passed to my elastic nodes. This way I could build an alert if the ingest increases out of nowhere.

@zengxilong
Copy link
Author

Where are we with this PR? I would be interested to get to know how much ingest is being passed to my elastic nodes. This way I could build an alert if the ingest increases out of nowhere.

cc @sysadmind

@rgarcia89
Copy link

@SuperQ do you have time to review the following PR?

@dima-sh-papaya
Copy link

ehh 😞 this seems useful

@zengxilong
Merge branch 'master' into feature/add_ingest_metrics
4c10dff 
# Conflicts:
#	.gitignore
#	collector/nodes_response.go
SuperQ
SuperQ reviewed Apr 23, 2025
View reviewed changes
.gitignore
.tarballs
/vendor
.idea
vendor/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to keep consistent with .gitignore of the main branch

@zengxilong
feat: add test
11a2901 
Signed-off-by: zengxilong <zengxilonglh@gmail.com>
@zengxilong zengxilong force-pushed the feature/add_ingest_metrics branch from 900c6c5 to bce6aba Compare April 23, 2025 08:12
@zengxilong
feat: add readme
44f6a6a 
Signed-off-by: zengxilong <zengxilonglh@gmail.com>
@zengxilong zengxilong force-pushed the feature/add_ingest_metrics branch from 8115534 to 44f6a6a Compare April 23, 2025 08:48
@Pyouba
Copy link

Pyouba commented Aug 4, 2025

up up 😄

@sysadmind
Copy link
Contributor

All of the checks seem to be missing here. I'm not sure why, but I think it will need a rebase at this point. I would also like to see the README changes separate from any whitespace changes because it makes it hard to read the diff otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperQ SuperQ SuperQ left review comments

@sysadmind sysadmind Awaiting requested review from sysadmind

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zengxilong @rgarcia89 @dima-sh-papaya @Pyouba @sysadmind @SuperQ