Refactor tests for nodes collector #936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sysadmind
commented
Sep 28, 2024
sysadmind
commented
- Drop extra test for authenticated requests to elasticsearch. Auth is common across all collectors, so it doesn't make sense to have specific tests for an individual collector.
- Add missing descriptions
- Drop tests for minor versions besides the most recent. The output is very large for this collector, and there is little value in testing every single minor version.
- Update tests to test the output of the metrics
- Refactor the node roles metric to have the role be dynamic, and to export 0 values for roles that are missing.
- Drop extra test for authenticated requests to elasticsearch. Auth is common across all collectors, so it doesn't make sense to have specific tests for an individual collector. - Add missing descriptions - Drop tests for minor versions besides the most recent. The output is very large for this collector, and there is little value in testing every single minor version. - Update tests to test the output of the metrics - Refactor the node roles metric to have the role be dynamic, and to export 0 values for roles that are missing. Signed-off-by: Joe Adams <github@joeadams.io>
Signed-off-by: Joe Adams <github@joeadams.io>
Signed-off-by: Joe Adams <github@joeadams.io>
SuperQ
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.