Skip to content

Conversation

@prombot
Copy link
Collaborator

@prombot prombot commented Jun 22, 2020

Propagating changes from prometheus/prometheus default branch.

Signed-off-by: prombot <prometheus-team@googlegroups.com>



Copyright (c) 2009 The Go Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're vendoring code from the gopls project, we should still keep their license around.

It probably should be added to the list of synced files in internal/vendored/.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should happen in the same PR or before merging this PR, to avoid getting the master branch in a state where license terms are violated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be better to also vendor the LICENSE in those directories.

@@ -0,0 +1,300 @@
# Copyright 2018 The Prometheus Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not using any of this yet, but I guess it doesn't hurt to have it around and start using some of these common rules in the future.

@slrtbtfs slrtbtfs self-assigned this Jun 22, 2020
@SuperQ
Copy link
Contributor

SuperQ commented Jun 22, 2020

I've done some fixing up of the sync script. We can close this and it should open a more sane PR.

@SuperQ SuperQ closed this Jun 22, 2020
@Nexucis Nexucis deleted the repo_sync branch June 22, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants