Invalid APISecret error if only set default api_secret for wechat#1888
Merged
stuartnelson3 merged 1 commit intoprometheus:masterfrom May 15, 2019
Merged
Invalid APISecret error if only set default api_secret for wechat#1888stuartnelson3 merged 1 commit intoprometheus:masterfrom
stuartnelson3 merged 1 commit intoprometheus:masterfrom
Conversation
Member
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
The change looks legit to me as it removes some confusion about the Wechat configuration and is consistent with what we advocate for the other receivers (eg no templating for secrets and passwords). See #1385 (comment).
Can you also remove this line:
alertmanager/template/default.tmpl
Line 64 in 935fb91
MIBc
force-pushed
the
master
branch
2 times, most recently
from
79138a8 to
6c90423
Compare
stuartnelson3
approved these changes
May 15, 2019
Contributor
Author
|
Thanks for your review @simonpasquier . I have updated it . |
Contributor
|
Because the template was changed, you need to regenerate the assets. Can you run |
Contributor
Author
|
Yes. I see that. |
Signed-off-by: lvjiawei <lvjiawei@cmss.chinamobile.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1887
Signed-off-by: lvjiawei lvjiawei@cmss.chinamobile.com