notify/pagerduty: fix images#1931
Merged
simonpasquier merged 1 commit intoprometheus:masterfrom Jun 24, 2019
Merged
Conversation
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Contributor
|
I've verified this change using https://v2.developer.pagerduty.com/docs/send-an-event-events-api-v2, and successfully created an image link in a real alert using: |
mikebryant
approved these changes
Jun 19, 2019
Member
Author
|
Thanks a lot @mikebryant |
simonpasquier
force-pushed
the
fix-pd-images
branch
3 times, most recently
from
36dcd6e to
e5acd61
Compare
stuartnelson3
approved these changes
Jun 24, 2019
simonpasquier
added a commit
to simonpasquier/docs
that referenced
this pull request
Jun 24, 2019
See prometheus/alertmanager#1931 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
added a commit
to simonpasquier/docs
that referenced
this pull request
Jul 10, 2019
See prometheus/alertmanager#1931 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
brian-brazil
pushed a commit
to prometheus/docs
that referenced
this pull request
Jul 30, 2019
* Update OpsGenie configuration for AM v0.18 * Fix PagerDuty image configuration See prometheus/alertmanager#1931 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
DuskEagle
pushed a commit
to DuskEagle/alertmanager
that referenced
this pull request
Aug 1, 2019
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
eightnoneone
pushed a commit
to eightnoneone/docs
that referenced
this pull request
Apr 20, 2020
* Update OpsGenie configuration for AM v0.18 * Fix PagerDuty image configuration See prometheus/alertmanager#1931 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1784
For clarity, I've chosen to rename the field
texttohrefin the configuration though it could break people (but I suspect that it isn't widely used).Unfortunately I don't have a way to validate it. Maybe @seanhoughton, @sbueringer, @mikebryant or @adamdecaf could help (I've looked at the Git history for people that contributed to the PagerDuty code).