Add Fingerprint to template data#1945
Merged
stuartnelson3 merged 1 commit intoprometheus:masterfrom Jul 22, 2019
Merged
Conversation
Signed-off-by: Paul Traylor <paul.traylor@linecorp.com>
Contributor
Author
|
Not sure who is the correct person to ask for a review @simonpasquier @stuartnelson3 |
stuartnelson3
approved these changes
Jul 2, 2019
Contributor
stuartnelson3
left a comment
stuartnelson3
left a comment
There was a problem hiding this comment.
Sorry for the delay! @simonpasquier any comments?
Contributor
Author
|
@simonpasquier have you been able to take a look? |
1 task
marcusteixeira
added a commit
to marcusteixeira/alertmanager2es
that referenced
this pull request
Nov 4, 2019
Add a support do Fingerprint ID in alertsnitch.
Fingerprint:
prometheus/alertmanager#1945
https://stackoverflow.com/questions/51511763/alertmanager-unique-id
|
Should it be added to docs https://prometheus.io/docs/alerting/notifications/ ? |
Member
|
@Paxa yes, feel free to open the PR if you wish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #1903 by adding the Fingerprint to the template data. My goal for this is to have the fingerprint in the Webhook data for downstream consumption.