Remove unneeded nil check before ranging over slice#2900
Merged
roidelapluie merged 1 commit intomainfrom May 2, 2022
Merged
Conversation
Member
|
Please rebase once #2904 is merged, to make sure the CI behaves. |
Ranging over a nil slice is just a noop as well. Signed-off-by: Julius Volz <julius.volz@gmail.com>
juliusv
force-pushed
the
remove-unneeded-nil-check
branch
from
add9ff1 to
6849edc
Compare
Member
Author
|
Rebased, thanks. |
Member
|
Thanks |
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
Ranging over a nil slice is just a noop as well. Signed-off-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ranging over a nil slice is just a noop as well.
Signed-off-by: Julius Volz julius.volz@gmail.com