Rename matchers package to matcher singular#3777
Merged
simonpasquier merged 3 commits intoprometheus:mainfrom Jun 21, 2024
Merged
Rename matchers package to matcher singular#3777simonpasquier merged 3 commits intoprometheus:mainfrom
simonpasquier merged 3 commits intoprometheus:mainfrom
Conversation
I realized that we had named the package plural "matchers" when its idiomatic in Go to use singular package names. Signed-off-by: George Robinson <george.robinson@grafana.com>
Signed-off-by: George Robinson <george.robinson@grafana.com>
Signed-off-by: George Robinson <george.robinson@grafana.com>
Closed
TheMeier
pushed a commit
to TheMeier/alertmanager
that referenced
this pull request
Sep 29, 2024
* Rename matchers package to matcher singular I realized that we had named the package plural "matchers" when its idiomatic in Go to use singular package names. --------- Signed-off-by: George Robinson <george.robinson@grafana.com>
tjhop
pushed a commit
to tjhop/alertmanager
that referenced
this pull request
Nov 13, 2025
* Rename matchers package to matcher singular I realized that we had named the package plural "matchers" when its idiomatic in Go to use singular package names. --------- Signed-off-by: George Robinson <george.robinson@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that we had named the package plural
matcherswhen its idiomatic in Go to use singular package names.