chore(deps): migrate aws sdk to v2#4482
Merged
sysadmind merged 1 commit intoprometheus:mainfrom Aug 11, 2025
Merged
Conversation
sysadmind
reviewed
Aug 1, 2025
pehlicd
force-pushed
the
migrate-aws-sdk
branch
3 times, most recently
from
65cc056 to
fd1a8b3
Compare
Contributor
Author
|
Hey @sysadmind , can I get another review 🙂 |
sysadmind
approved these changes
Aug 4, 2025
Contributor
|
@pehlicd are you a user of the SNS notifications? I don't have an AWS account to test these changes with and I want to make sure we have tested against the real AWS API if at all possible. |
Contributor
Author
|
@sysadmind Unfortunately I don't have an aws env either. However, I have manually validated these changes using localstack. If testing on a real aws env necessary, I can spin one up and test it out. |
pehlicd
force-pushed
the
migrate-aws-sdk
branch
from
fd1a8b3 to
2c97e06
Compare
Signed-off-by: pehlicd <furkanpehlivan34@gmail.com>
pehlicd
force-pushed
the
migrate-aws-sdk
branch
from
2c97e06 to
83b8946
Compare
Contributor
Author
|
Hey @sysadmind, I tried with actual aws environment as well and it is working. Can we continue and merge this one? |
sysadmind
approved these changes
Aug 11, 2025
Contributor
|
I think it's good to merge at this point. Thanks for the legwork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4481