feat: Add custom labels to exemplars#2191
Merged
Merged
Conversation
jaydeluca
force-pushed
the
exemplar-labels-clean
branch
from
c98d047 to
4220f82
Compare
zeitlinger
requested changes
Jun 5, 2026
Member
zeitlinger
left a comment
zeitlinger
left a comment
There was a problem hiding this comment.
One review item: the new exemplar label suppliers are documented as applying to automatically-sampled exemplars, but the current implementation also injects them into custom exemplars via updateCustomExemplar(). That changes the semantics of observeWithExemplar/incWithExemplar, which no longer remain fully caller-controlled when a global supplier is installed. Please avoid merging the extra supplier labels on the custom-exemplar path (while keeping trace/span enrichment if desired).
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
jaydeluca
force-pushed
the
exemplar-labels-clean
branch
from
efbcfb8 to
0e8dfb6
Compare
zeitlinger
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1994