Skip to content

Conversation

@eliezio
Copy link
Contributor

@eliezio eliezio commented Oct 17, 2016

fixed doc issues

@brian-brazil brian-brazil merged commit 440c3ca into prometheus:master Oct 17, 2016
@brian-brazil
Copy link
Contributor

Thanks!

@eliezio eliezio deleted the enable-prometheus-endpoint-rev6 branch October 17, 2016 12:49
@fiunchinho
Copy link
Contributor

fiunchinho commented Oct 23, 2016

When will this be released? Thanks!

@brian-brazil
Copy link
Contributor

Next week sometime is the plan.

@fiunchinho
Copy link
Contributor

I was trying to test it locally just copy and pasting the files from this pull request, but I can't get it to work properly. After adding the @EnablePrometheusEndpoint() annotation to my Application, I can visit the /prometheus endpoint but with empty result.
The /metrics endpoint is returning the usual response.

prometheus

Do I need to do anything else?

@eliezio
Copy link
Contributor Author

eliezio commented Oct 24, 2016

The metrics you are seeing through the /metrics endpoint are those that were auto-configured by Spring Boot.
To see these metrics also through /prometheus endpoint, you need to instantiate a SpringBootMetricsCollector bean as stated on its documentation (see https://prometheus.io/client_java/io/prometheus/client/spring/boot/SpringBootMetricsCollector.html).
Maybe there should be a second annotation (i.e.: @ExportPublicMetricsToPrometheus) to simplify this task.

@fiunchinho
Copy link
Contributor

You are right. It works now, thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants