- 
                Notifications
    
You must be signed in to change notification settings  - Fork 337
 
          Add WithDialTLSContextFunc option
          #324
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 
           Unfortunately, the   | 
    
| 
           Do we need to do the same with  Lines 369 to 378 in d9fc5f4 
  | 
    
| 
           No.  | 
    
| 
           To remove go 1.13, we would need to see with client_golang. Otherwise, I'd suggest that you go get this commit in your fork so we can assess of the feature would work.  | 
    
| 
           Build tags with version constraints could also be an option.  | 
    
| 
           Can you please rebase this so we can continue working on this?  | 
    
| 
           Sure, but if I remember correctly what was holding this up was the usage of this new function: prometheus/prometheus#9482 (comment).  | 
    
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
d9fc5f4    to
    e12768b      
    Compare
  
    
This PR adds needed functionality to implement prometheus/prometheus#4827, in the form of the
WithDialTLSContextFuncoption and__server_name__label.(slightly incorrect) Example implementation: