Skip to content

collector: replace fmt.Sprintf with strconv.Itoa in perfCollector#2174

Merged
SuperQ merged 1 commit intoprometheus:masterfrom
mdlayher:mdl-itoa
Oct 22, 2021
Merged

collector: replace fmt.Sprintf with strconv.Itoa in perfCollector#2174
SuperQ merged 1 commit intoprometheus:masterfrom
mdlayher:mdl-itoa

Conversation

@mdlayher
Copy link
Contributor

Signed-off-by: Matt Layher mdlayher@gmail.com

No need to make use of reflection or a temporary variable for these one-liner conversions.

Signed-off-by: Matt Layher <mdlayher@gmail.com>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 8b198ce into prometheus:master Oct 22, 2021
@mdlayher mdlayher deleted the mdl-itoa branch October 22, 2021 19:12
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants