Skip to content

Add example of translating new metrics to old format in case of migration to 1.16 version#982

Merged
SuperQ merged 4 commits intoprometheus:masterfrom
ivan-kiselev:master
Jul 2, 2018
Merged

Add example of translating new metrics to old format in case of migration to 1.16 version#982
SuperQ merged 4 commits intoprometheus:masterfrom
ivan-kiselev:master

Conversation

@ivan-kiselev
Copy link

Hello people!

Seems like there's a misconfiguration in the rules for the backward compatibility between node_exporters < 1.16 and 1.16.

As said in the changelog - node_cpu_seconds_total is a new metric name, and the node_cpu is the old one, so they should be put vice-versa.

@ivan-kiselev
Copy link
Author

Oh well, I think I got your idea. These rules are for translating old format to the new one.

So you wanted users to make all the metrics in the new format and redo all the Grafana dashboards, right?

@ivan-kiselev ivan-kiselev changed the title fix misconfigured rule for backward compatibility WIP: fix misconfigured rule for backward compatibility Jun 21, 2018
@ivan-kiselev ivan-kiselev changed the title WIP: fix misconfigured rule for backward compatibility Add example of translating new metrics to old format in case of migration to 1.16 version Jun 21, 2018
@ivan-kiselev
Copy link
Author

So, I've added new example that is basically just does opposite things then yours.

Motivation: I want to keep all the software I run in infrastructure up-to-date. But I don't want to redo hundreds of dashboards because of upgrading node_exporter. I know that it should happen one day, but, for example, not today :P

@discordianfish
Copy link
Member

Hi,

thanks! You'd need to sign you commits, see https://github.com/prometheus/node_exporter/blob/master/CONTRIBUTING.md#contributing

In general not sure we need this here but I guess if it's useful there isn't harm. @SuperQ thoughts?

@SuperQ
Copy link
Member

SuperQ commented Jun 23, 2018

I'm not sure we really need this, but I don't see any harm in providing the sample.

We (GitLab) didn't go this route for our Grafana, we did a sweep of dashboards and added both new and old metric queries to the dashboards, this was far more seamless and doesn't have the duplicated storage requirements.

@ivan-kiselev
Copy link
Author

Well, it's a nice thing to do, of-course, to change everything to the new format at the very first place, but when you really have hundreds of dashboards, custom alerts and recording rules - it's a task that would take a while, day or couple for anyone, and it's quite expensive for just upgrading node_exporter version and it's the time you may probably not have right now.

So, if you guys think it's not the case - feel free to close the PR, since I've already applied it in our infrastructure, but I think someone like me would really thank you for adding such a doc there.

@ivan-kiselev ivan-kiselev force-pushed the master branch 2 times, most recently from 99b913b to e36aa44 Compare June 26, 2018 09:02
Ivan Kiselev added 4 commits June 26, 2018 11:03
Signed-off-by: Ivan Kiselev <ivan@messagebird.com>
Signed-off-by: Ivan Kiselev <ivan@messagebird.com>
Signed-off-by: Ivan Kiselev <ivan@messagebird.com>
Signed-off-by: Ivan Kiselev <ivan@messagebird.com>
@ivan-kiselev
Copy link
Author

sorry for the delay guys, all the commits are signed now.

@SuperQ SuperQ merged commit ae90bac into prometheus:master Jul 2, 2018
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
…tion to 1.16 version (prometheus#982)

Add additional example of how to save old metrics

Signed-off-by: Ivan Kiselev <ivan@messagebird.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants