fix: preserve active payload severities#1046
Conversation
Performance BenchmarksCompared
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b44107acc0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25e9c4180e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51c7c572da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb9ae83109
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6215deca0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The previous exempt set covered S2xx pickle opcodes, a handful of S4xx/S5xx codes, and a keyword fallback over message/check name. It still let S1xx code-execution primitives (os/sys/subprocess/eval/compile/__import__/ importlib/runpy/webbrowser/ctypes/builtins) and HIGH-severity S3xx network primitives (raw sockets, ftplib, telnetlib, exfiltration) through when the emitter used a generic message — concretely, `flax_msgpack_scanner`'s "Suspicious code pattern detected: <regex>" CRITICAL findings were still being silently INFO-downgraded on whitelisted HuggingFace models. Adds those rule codes to `_WHITELIST_DOWNGRADE_EXEMPT_RULE_CODES` and switches the keyword fallback to word-boundary regex matching so incidental substrings like "executable" inside "ExecuTorch" or "rce" inside "force" no longer over-suppress legitimate downgrades. Adds parametrized regression coverage for S101–S110, S115, S301, S304, S305, S310, and for the word-boundary substring cases. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…itelist-active-payloads # Conflicts: # CHANGELOG.md
2 participants
Summary
Finding
Fixes finding 4: whitelist can downgrade active payloads to INFO.
Validation