Skip to content

Detect message handlers with popo-messages #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2018
Merged

Detect message handlers with popo-messages #73

merged 4 commits into from
Jul 15, 2018

Conversation

@UFOMelkor
Copy link
Member

@UFOMelkor UFOMelkor commented May 2, 2018 •
edited
Loading

Auto-detection will be possible with handlers that have a __invoke method.

See #63 (comment)

Fixes #72

@coveralls
Copy link

coveralls commented May 2, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 229

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.138%
Totals Coverage Status
Change from base Build 224: 0.1%
Covered Lines: 401
Relevant Lines: 471
💛 - Coveralls

@UFOMelkor UFOMelkor force-pushed the feature/detect-invokables-with-popos branch from 3c5571f to f15cf64 Compare May 2, 2018 06:47
@UFOMelkor UFOMelkor changed the title [WIP] Verify that popo command handlers cannot be automatically detected Detect message handlers with popo-messages May 2, 2018
codeliner
codeliner requested changes May 3, 2018
View reviewed changes
doc/routing.md Outdated

> **Important:** Automatic message detection can only detect handlers where either
> the message implements `Prooph\Common\Messaging\HasMessageName` or the
> name of the message is `__invoke`. In both cases the object must be a non abstract class.
Copy link
Member

@codeliner codeliner May 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/message/method ?

@UFOMelkor
Copy link
Member Author

UFOMelkor commented May 3, 2018 •
edited
Loading

Good catch! I'll fix tomorrow 👍

@codeliner codeliner merged commit 901ef47 into prooph:master Jul 15, 2018
@codeliner
Copy link
Member

codeliner commented Jul 15, 2018

sorry, missed the update. Finally merged ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codeliner codeliner codeliner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@UFOMelkor @coveralls @codeliner