Skip to content

Conversation

@kostis
Copy link
Collaborator

@kostis kostis commented Oct 16, 2019

Reverts #213

@kostis
Copy link
Collaborator Author

kostis commented Oct 16, 2019

Continuing the discussion of #213, I will revert this.

@ferd Should I also add a {project_plugins, [rebar3_hex]} to rebar.config or not? (This part is not so clear to me.)

Kostis, who is (slowly) entering the brave rebar3 world...

@kostis kostis mentioned this pull request Oct 16, 2019
@ferd
Copy link
Contributor

ferd commented Oct 16, 2019

No need to, that plugin is something I tend to maintain globally.

Project plugins are more useful for example when people install the rebar3 plugin for proper I have written (https://github.com/ferd/rebar3_proper) which lets you expose the rebar3 proper command when using your app at the root, but won't include it when the app is included as a dep (and therefore won't make rebar3 proper available to the app that includes the dep that uses PropEr)

@kostis kostis merged commit cfbd21e into master Oct 16, 2019
@kostis kostis deleted the revert-213-add-rebar3-hex branch October 16, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants