Unused keyword args bugfixes and error silencing

Author: lukelbd

proplot/axes.py

@@ -3338,11 +3338,12 @@ def __init__(self, *args, map_projection=None, **kwargs):
         else:
             self.set_global()
 
-    def _format_apply(
+    def _format_apply(  # noqa: U100
         self, patch_kw, lonlim, latlim, boundinglat,
         lonlines, latlines, latmax, lonarray, latarray
     ):
         """Apply formatting to cartopy axes."""
+        # NOTE: Cartopy seems to handle latmax automatically.
         import cartopy.feature as cfeature
         import cartopy.crs as ccrs
         from cartopy.mpl import gridliner
@@ -3400,8 +3401,10 @@ def _format_apply(
                 eps = 1e-10  # bug with full -180, 180 range when lon_0 != 0
                 lat0 = (90 if north else -90)
                 lon0 = self.projection.proj4_params.get('lon_0', 0)
-                extent = [lon0 - 180 + eps,
-                          lon0 + 180 - eps, boundinglat, lat0]
+                extent = [
+                    lon0 - 180 + eps, lon0 + 180 - eps,
+                    boundinglat, lat0
+                ]
                 self.set_extent(extent, crs=ccrs.PlateCarree())
                 self._boundinglat = boundinglat
         else:

proplot/axistools.py

@@ -394,7 +394,7 @@ class AutoFormatter(mticker.ScalarFormatter):
     """
     def __init__(
         self, *args,
-        zerotrim=None, precision=None, tickrange=None,
+        zerotrim=None, tickrange=None,
         prefix=None, suffix=None, negpos=None, **kwargs
     ):
         """
@@ -477,7 +477,7 @@ def __call__(self, x, pos=None):
         return sign + self._prefix + string + self._suffix + tail
 
 
-def SimpleFormatter(*args, precision=6, zerotrim=True, **kwargs):
+def SimpleFormatter(precision=6, zerotrim=True):
     """
     Return a `~matplotlib.ticker.FuncFormatter` instance that replicates the
     `zerotrim` feature from `AutoFormatter`. This is more suitable for
@@ -540,7 +540,7 @@ def f(x, pos):  # must accept location argument
     return mticker.FuncFormatter(f)
 
 
-def _scale_factory(scale, axis, *args, **kwargs):
+def _scale_factory(scale, axis, *args, **kwargs):  # noqa: U100
     """If `scale` is a `~matplotlib.scale.ScaleBase` instance, do nothing. If
     it is a registered scale name, look up and instantiate that scale."""
     if isinstance(scale, mscale.ScaleBase):
@@ -938,7 +938,7 @@ class PowerScale(_ScaleBase, mscale.ScaleBase):
     name = 'power'
     """The registered scale name."""
 
-    def __init__(self, power=1, inverse=False, *, minpos=1e-300, **kwargs):
+    def __init__(self, power=1, inverse=False, *, minpos=1e-300):
         """
         Parameters
         ----------
@@ -1025,7 +1025,7 @@ class ExpScale(_ScaleBase, mscale.ScaleBase):
     """The registered scale name."""
 
     def __init__(
-        self, a=np.e, b=1, c=1, inverse=False, minpos=1e-300, **kwargs
+        self, a=np.e, b=1, c=1, inverse=False, minpos=1e-300,
     ):
         """
         Parameters
@@ -1134,7 +1134,7 @@ def __init__(self, thresh=85.0):
         self._default_major_formatter = Formatter('deg')
         self._default_smart_bounds = True
 
-    def limit_range_for_scale(self, vmin, vmax, minpos):
+    def limit_range_for_scale(self, vmin, vmax, minpos):  # noqa: U100
         """Return *vmin* and *vmax* limited to some range within
         +/-90 degrees (exclusive)."""
         return max(vmin, -self._thresh), min(vmax, self._thresh)
@@ -1208,7 +1208,7 @@ def __init__(self):
         self._default_major_formatter = Formatter('deg')
         self._default_smart_bounds = True
 
-    def limit_range_for_scale(self, vmin, vmax, minpos):
+    def limit_range_for_scale(self, vmin, vmax, minpos):  # noqa: U100
         """Return *vmin* and *vmax* limited to some range within
         +/-90 degrees (inclusive)."""
         return max(vmin, -90), min(vmax, 90)
@@ -1267,7 +1267,7 @@ class CutoffScale(_ScaleBase, mscale.ScaleBase):
     name = 'cutoff'
     """The registered scale name."""
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *args):
         """
         Parameters
         ----------
@@ -1382,7 +1382,7 @@ class InverseScale(_ScaleBase, mscale.ScaleBase):
     name = 'inverse'
     """The registered scale name."""
 
-    def __init__(self, **kwargs):
+    def __init__(self):
         super().__init__()
         self._transform = InverseTransform()
         # self._default_major_formatter = Fromatter('log')

proplot/rctools.py

@@ -648,7 +648,7 @@ def _update_from_file(file):
                 rcParams.update(rc)
 
 
-def _write_defaults(filename, comment=True, overwrite=False):
+def _write_defaults(filename, comment=True):
     """
     Save a file to the specified path containing the default `rc` settings.
 
@@ -658,8 +658,6 @@ def _write_defaults(filename, comment=True, overwrite=False):
         The path.
     comment : bool, optional
         Whether to "comment out" each setting.
-    overwrite : bool, optional
-        Whether to overwrite existing files.
     """
     def _tabulate(rcdict):
         string = ''
@@ -815,7 +813,7 @@ def _update(rcdict, newdict):
             _update(rcParamsLong, rc_long)
             _update(rcParams, rc)
 
-    def __exit__(self, *args):
+    def __exit__(self, *args):  # noqa: U100
         """Restore settings from the most recent context block."""
         if not self._context:
             raise RuntimeError(
@@ -829,11 +827,11 @@ def __exit__(self, *args):
             rcParams.update(rc)
         del self._context[-1]
 
-    def __delitem__(self, *args):
+    def __delitem__(self, item):  # noqa: 100
         """Raise an error. This enforces pseudo-immutability."""
         raise RuntimeError('rc settings cannot be deleted.')
 
-    def __delattr__(self, *args):
+    def __delattr__(self, item):  # noqa: 100
         """Raise an error. This enforces pseudo-immutability."""
         raise RuntimeError('rc settings cannot be deleted.')
 

proplot/styletools.py

@@ -944,7 +944,7 @@ def punched(self, cut=None, name=None, **kwargs):
         right_center = 0.5 + cut / 2
         cmap_left = self.truncated(0, left_center)
         cmap_right = self.truncated(right_center, 1)
-        return cmap_left.concatenate(cmap_right, name=name)
+        return cmap_left.concatenate(cmap_right, name=name, **kwargs)
 
     def reversed(self, name=None, **kwargs):
         """
@@ -1090,7 +1090,8 @@ def shifted(self, shift=None, name=None, **kwargs):
         cmap_left = self.truncated(shift, 1)
         cmap_right = self.truncated(0, shift)
         return cmap_left.concatenate(
-            cmap_right, ratios=(1 - shift, shift), name=name)
+            cmap_right, ratios=(1 - shift, shift), name=name, **kwargs
+        )
 
     def truncated(self, left=None, right=None, name=None, **kwargs):
         """
@@ -1325,6 +1326,8 @@ def concatenate(self, *args, name=None, N=None, **kwargs):
         N : int, optional
             The number of colors in the colormap lookup table. Default is
             the number of colors in the concatenated lists.
+        **kwargs
+            Passed to `~ListedColormap.updated`.
         """
         if not args:
             raise ValueError(
@@ -1338,7 +1341,7 @@ def concatenate(self, *args, name=None, N=None, **kwargs):
         if name is None:
             name = '_'.join(cmap.name for cmap in cmaps)
         colors = [color for cmap in cmaps for color in cmap.colors]
-        return self.updated(colors, name, N or len(colors))
+        return self.updated(colors, name, N or len(colors), **kwargs)
 
     def save(self, path=None):
         """
@@ -2456,8 +2459,8 @@ def Norm(norm, levels=None, **kwargs):
         Key(s)                           Class
         ===============================  ===============================
         ``'midpoint'``, ``'zero'``       `MidpointNorm`
-        ``'segments'``, ``'segmented'``  `LinearSegmentedNorm`
-        ``'none'``, ``'null'``           `~matplotlib.colors.NoNorm`
+        ``'segmented'``, ``'segments'``  `LinearSegmentedNorm`
+        ``'null'``, ``'none'``           `~matplotlib.colors.NoNorm`
         ``'linear'``                     `~matplotlib.colors.Normalize`
         ``'log'``                        `~matplotlib.colors.LogNorm`
         ``'power'``                      `~matplotlib.colors.PowerNorm`
@@ -2516,7 +2519,7 @@ class BinNorm(mcolors.BoundaryNorm):
        If it is ``None``, they are not changed. Possible normalizers include
        `~matplotlib.colors.LogNorm`, which makes color transitions linear in
        the logarithm of the value, or `LinearSegmentedNorm`, which makes
-       color transitions linear in the **index** of the level array.
+       color transitions linear in the *index* of the level array.
     2. Possible colormap coordinates, corresponding to bins delimited by the
        normalized `levels` array, are calculated.  In this case, the bin
        centers are simply ``[1.5, 4.5, 7.5, 10.5, 13.5]``, which gives us
@@ -2528,7 +2531,7 @@ class BinNorm(mcolors.BoundaryNorm):
        color as the nearest in-bounds values. For `extend` equal to ``'both'``,
        the bins are ``[0, 0.16, 0.33, 0.5, 0.66, 0.83, 1]`` --
        out-of-bounds values are given distinct colors. This makes sure your
-       colorbar always shows the **full range of colors** in the colormap.
+       colorbar always shows the *full range of colors* in the colormap.
     4. Whenever `BinNorm.__call__` is invoked, the input value normalized by
        `norm` is compared against the normalized `levels` array. Its bin index
        is determined with `numpy.searchsorted`, and its corresponding

proplot/subplots.py

@@ -101,8 +101,8 @@ def __init__(self, objs, n=1, order='C'):
     def __repr__(self):
         return 'subplot_grid([' + ', '.join(str(ax) for ax in self) + '])'
 
-    def __setitem__(self, key, value):
-        """Pseudo immutability. Raises error."""
+    def __setitem__(self, key, value):  # noqa: U100
+        """Raise an error. This enforces pseudo immutability."""
         raise LookupError('subplot_grid is immutable.')
 
     def __getitem__(self, key):
@@ -803,7 +803,7 @@ def __enter__(self):
         for label in self._labels:
             label.set_visible(False)
 
-    def __exit__(self, *args):
+    def __exit__(self, *args):  # noqa: U100
         for label in self._labels:
             label.set_visible(True)
 

proplot/utils.py

@@ -29,7 +29,7 @@ def __enter__(self):
         if BENCHMARK:
             self.time = time.perf_counter()
 
-    def __exit__(self, *args):
+    def __exit__(self, *args):  # noqa: U100
         if BENCHMARK:
             print(f'{self.message}: {time.perf_counter() - self.time}s')
 
@@ -47,7 +47,7 @@ def __enter__(self):
         for key, value in self._kwargs.items():
             setattr(self._obj, key, value)
 
-    def __exit__(self, *args):
+    def __exit__(self, *args):  # noqa: U100
         for key in self._kwargs.keys():
             if key in self._kwargs_orig:
                 setattr(self._obj, key, self._kwargs_orig[key])
@@ -89,7 +89,7 @@ def decorator(*args, **kwargs):
     return decorator
 
 
-def _format_warning(message, category, filename, lineno, line=None):
+def _format_warning(message, category, filename, lineno, line=None):  # noqa: U100, E501
     """Simple format for warnings issued by ProPlot. See the
     `internal warning call signature \
 <https://docs.python.org/3/library/warnings.html#warnings.showwarning>`__

proplot/wrappers.py

@@ -1060,7 +1060,7 @@ def hist_wrapper(self, func, x, bins=None, **kwargs):
     return func(self, x, bins=bins, **kwargs)
 
 
-def barh_wrapper(
+def barh_wrapper(  # noqa: U100
     self, func, y=None, width=None, height=0.8, left=None, **kwargs
 ):
     """Wraps %(methods)s, usage is same as `bar_wrapper`."""
@@ -1403,8 +1403,10 @@ def text_wrapper(
         facecolor, bgcolor = kwargs['color'], bordercolor
         if invert:
             facecolor, bgcolor = bgcolor, facecolor
-        kwargs = {'linewidth': linewidth,
-                  'foreground': bgcolor, 'joinstyle': 'miter'}
+        kwargs = {
+            'linewidth': linewidth,
+            'foreground': bgcolor, 'joinstyle': 'miter'
+        }
         obj.update({
             'color': facecolor,
             'zorder': 100,
@@ -1417,7 +1419,6 @@ def text_wrapper(
 def cycle_changer(
     self, func, *args,
     cycle=None, cycle_kw=None,
-    markers=None, linestyles=None,
     label=None, labels=None, values=None,
     legend=None, legend_kw=None,
     colorbar=None, colorbar_kw=None,