Skip to content

Commit c0d0483

Browse files
committed
Fix issue where drawing violins w/o error bars causes error
1 parent d7c87e7 commit c0d0483

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

proplot/axes/plot.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3521,18 +3521,18 @@ def _apply_violinplot(self, x, y, vert=True, **kwargs):
35213521
if kw.pop('showextrema', None):
35223522
warnings._warn_proplot('Ignoring showextrema=True.')
35233523

3524-
# Parse and control error bars
3524+
# Add error bars and violins
35253525
x, y, kw = self._parse_plot1d(x, y, autoy=False, autoguide=False, vert=vert, **kw) # noqa: E501
35263526
y, kw = data._dist_reduce(y, **kw)
35273527
kw = self._parse_cycle(**kw)
35283528
*eb, kw = self._plot_errorbars(x, y, vert=vert, default_boxes=True, **kw) # noqa: E501
3529-
3530-
# Call function
35313529
kw.pop('labels', None) # already applied in _parse_plot1d
3532-
kw.update({'showmeans': False, 'showmedians': False, 'showextrema': False})
35333530
kw.setdefault('positions', x)
3534-
y = kw.pop('distribution', None) # 'y' was changes in data._dist_reduce
3535-
obj = self._plot_native('violinplot', y, vert=vert, **kw)
3531+
y = _not_none(kw.pop('distribution'), y) # might not have reduced the data
3532+
obj = self._plot_native(
3533+
'violinplot', y, vert=vert,
3534+
showmeans=False, showmedians=False, showextrema=False, **kw
3535+
)
35363536

35373537
# Modify body settings
35383538
artists = (obj or {}).get('bodies', ())

0 commit comments

Comments
 (0)