Skip to content

Fix: correct joint passage reward function (issue #145) #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

Fix: correct joint passage reward function (issue #145) #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebc397f
Fix: correct joint passage reward function (issue #145)
Benabdellah22 Oct 26, 2025
9090d25
fix
matteobettini Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions vmas/scenarios/joint_passage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,11 +458,10 @@ def reward(self, agent: Agent):
self.world.get_distance(a, passage)
<= self.min_collision_distance
] += self.collision_reward
for wall in self.walls:
self.collision_rew[
self.world.get_distance(a, wall)
<= self.min_collision_distance
] += self.collision_reward
for wall in self.walls:
self.collision_rew[
self.world.get_distance(a, wall) <= self.min_collision_distance
] += self.collision_reward

# Joint collisions
for p in self.passages:
Expand Down
11 changes: 5 additions & 6 deletions vmas/scenarios/joint_passage_size.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2022-2024.
# Copyright (c) 2022-2025.
# ProrokLab (https://www.proroklab.org/)
# All rights reserved.
import math
Expand Down Expand Up @@ -453,11 +453,10 @@ def reward(self, agent: Agent):
self.world.get_distance(a, passage)
<= self.min_collision_distance
] += self.collision_reward
for wall in self.walls:
self.collision_rew[
self.world.get_distance(a, wall)
<= self.min_collision_distance
] += self.collision_reward
for wall in self.walls:
self.collision_rew[
self.world.get_distance(a, wall) <= self.min_collision_distance
] += self.collision_reward

# Energy reward
if self.energy_reward_coeff != 0:
Expand Down