[Perf] Vectorized collisions and other major perf improvements #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteobettini
changed the title
matteobettini
changed the title
# Conflicts: # vmas/simulator/dynamics/kinematic_bicycle.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a MAJOR rework of the collsions and constraints engine.
While before the physics were vectorized in the enviornments but we were still doing a double for loop over agents to check collisions, now this has been reworked and the double loop has been replaced by vectorized code over the agents.
This will mean that in the interface of vmas nothing changes but envioronments will be up to 10000x faster and growing in the number of entities will not be a problem
cc @Acciorocketships @janblumenkamp @smorad @alexandrashaw10