refactor: upgrade routing #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for truthpost ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was
linked to
issues
Jun 5, 2023
Closed
gratestas
force-pushed
the
refactor/routing
branch
from
b4098c5 to
1ac3c91
Compare
This commit addresses a bug in the EthereumProvider component where the blockNumber was incorrectly changing based on chainId when calling the switchAppChain function. Since the fetchGraphMetadata function is asynchronous and relies on the chainId state, the blockNumber could being updated with a value from a different chain before the correct graphMetadata is fetched. The interval polling for fetching the graph metadata has been moved to a separate useEffect hook that runs whenever the chainId changes
gratestas
force-pushed
the
refactor/routing
branch
from
8d988f5 to
f172f9c
Compare
0xferit
previously approved these changes
Jun 12, 2023
| } | ||
|
|
||
| if (newPath !== location.pathname) { | ||
| navigate(newPath, { replace: true }); |
Member
There was a problem hiding this comment.
Why do we need to erase the history?
|
Kudos, SonarCloud Quality Gate passed!
|
0xferit
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.