-
Notifications
You must be signed in to change notification settings - Fork 0
Fetch users #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Fetch users #13
Conversation
| */ | ||
|
|
||
| 'use strict'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comments and documentation
| componentDidMount() { | ||
| const articleList = []; | ||
| for(let i=1; i<151; i++){ | ||
| const url = `https://hacker-news.firebaseio.com/v0/item/${i}.json?print=pretty`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fetching the first 150 articles of the site, and not the current articles.
To do that you would have had to use https://hacker-news.firebaseio.com/v0/topstories.json?print=pretty to get the top stories first and use the ids that are returned to fetch the story details
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3