Skip to content

Conversation

@psc478
Copy link
Owner

@psc478 psc478 commented Dec 9, 2017

Checkpoint Rubric

This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.

Checkpoint 1

  • All tests passed: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript: 30 points

Checkpoint 2

  • The application works as it should: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript and the DOM API: 30 points

Checkpoint 3

  • Use of React: 25 points
  • Accesses an API: 25 points
  • Proper use of documentation (commenting on code): 25 points
  • The application functions as it should: 25 points

*/

'use strict';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comments and documentation

componentDidMount() {
const articleList = [];
for(let i=1; i<151; i++){
const url = `https://hacker-news.firebaseio.com/v0/item/${i}.json?print=pretty`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fetching the first 150 articles of the site, and not the current articles.
To do that you would have had to use https://hacker-news.firebaseio.com/v0/topstories.json?print=pretty to get the top stories first and use the ids that are returned to fetch the story details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants