Space #7
Open
Space #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousifS
reviewed
Nov 12, 2017
| let crewMemberJob = this.crew[i].job; | ||
| console.log("Crew Member Job Type: "+(jobTypes[crewMemberJob])); | ||
| if (((jobTypes[crewMemberJob])==(this.type))||(this.crew[i].job=='programmer')){ | ||
| good2go = true; |
There was a problem hiding this comment.
i would define good2go as a local variable in the function and default it to false.
yousifS
reviewed
Nov 12, 2017
| good2go = true; | ||
| } | ||
| } | ||
| if (good2go==true){ |
There was a problem hiding this comment.
this if condition could just be if(good2go) {
yousifS
reviewed
Nov 12, 2017
| let assert = require('assert'); | ||
|
|
||
| let good2go = null; | ||
|
|
There was a problem hiding this comment.
Missing documentation on your functions and classes
yousifS
reviewed
Nov 12, 2017
| let x2 = Number(toWhere.charAt(0)); | ||
| let y2 = Number(toWhere.charAt(1)); | ||
| //If the player enters an empty square as whichPiece | ||
| if (game.board.grid[y1][x1]===null){ |
yousifS
reviewed
Nov 12, 2017
| console.log("The square you specified in response to 'Which piece?' has an 'X' piece in it. Please try again.") | ||
| return; | ||
| }else{ | ||
| if(game.board.grid[y2][x2]!=null){ |
yousifS
reviewed
Nov 12, 2017
| function Game() { | ||
|
|
||
| this.board = new Board(); | ||
| this.moveChecker = function(whichPiece, toWhere){ |
There was a problem hiding this comment.
I would expect that the the board's grid attribute would not be accessed directly from here.
yousifS
reviewed
Nov 12, 2017
| //checker.create per checker | ||
| }*/ | ||
|
|
||
| class Checker { |
There was a problem hiding this comment.
Missing function and class documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3