Skip to content

Commit 0701038

Browse files
committed
basic (ugly) date type coercion tests
1 parent 074779b commit 0701038

File tree

3 files changed

+24
-11
lines changed

3 files changed

+24
-11
lines changed

lib/client.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -256,15 +256,9 @@ var dateParser = function(isoDate) {
256256
throw new Error("Unidentifed tZone part " + type);
257257
}
258258
}
259-
console.log("tzAdjust " + tzAdjust);
260259
var utcOffset = Date.UTC(year, month, day, hour, min, seconds, mili);
261260
var date = new Date(utcOffset+(tzAdjust*1000*60));
262-
263-
264-
console.log(isoDate);
265-
console.log(date);
266-
console.log("");
267-
return isoDate;
261+
return date;
268262
};
269263

270264
Client.dataTypeParser = {

test/test-helper.js

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,26 @@ assert.emits = function(item, eventName, callback) {
3333
callback.apply(item, arguments);
3434
}
3535
});
36+
};
37+
38+
assert.UTCDate = function(actual, year, month, day, hours, min, sec, milisecond) {
39+
var actualYear = actual.getUTCFullYear();
40+
assert.equal(actualYear, year, "expected year " + year + " but got " + actualYear);
41+
42+
var actualDate = actual.getUTCDate();
43+
assert.equal(actualDate, day, "expected day " + day + " but got " + actualDate);
44+
45+
var actualHours = actual.getUTCHours();
46+
assert.equal(actualHours, hours, "expected hours " + hours + " but got " + actualHours);
47+
48+
var actualMin = actual.getUTCMinutes();
49+
assert.equal(actualMin, min, "expected min " + min + " but got " + actualMin);
50+
51+
var actualSec = actual.getUTCSeconds();
52+
assert.equal(actualSec, sec, "expected sec " + sec + " but got " + actualSec);
3653

54+
var actualMili = actual.getUTCMilliseconds();
55+
assert.equal(actualMili, milisecond, "expected milisecond " + milisecond + " but got " + actualMili);
3756
};
3857

3958
assert.equalBuffers = function(actual, expected) {

test/unit/client/typed-query-results.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,28 +68,28 @@ test('typed results', function() {
6868
dataTypeID: 1184,
6969
actual: '2010-10-31 14:54:13.74-0530',
7070
expected: function(val) {
71-
return false;
71+
assert.UTCDate(val, 2010, 9, 31, 9, 24, 13, 74);
7272
}
7373
},{
7474
name: 'timestampz with huge miliseconds in UTC',
7575
dataTypeID: 1184,
7676
actual: '2010-10-30 14:11:12.730838Z',
7777
expected: function(val) {
78-
return false;
78+
assert.UTCDate(val, 2010, 9, 30, 14, 11, 12, 730);
7979
}
8080
},{
8181
name: 'timestampz with no miliseconds',
8282
dataTypeID: 1184,
8383
actual: '2010-10-30 13:10:01+05',
8484
expected: function(val) {
85-
return false;
85+
assert.UTCDate(val, 2010, 9, 30, 18, 10, 01, 0);
8686
}
8787
},{
8888
name: 'timestamp',
8989
dataTypeID: 1114,
9090
actual: '2010-10-31 00:00:00',
9191
expected: function(val) {
92-
return false;
92+
assert.UTCDate(val, 2010, 9, 31, 0, 0, 0, 0);
9393
}
9494
}];
9595

0 commit comments

Comments
 (0)