-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/version command #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kooksee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new version command to the protobuild command-line interface, allowing users to easily retrieve detailed build information. This functionality is enabled by enhancing the build process to embed version, project, build time, and commit ID directly into the compiled binary, leveraging a common funk utility library for consistent versioning across related projects.
Highlights
- New Feature: Version Command: I've added a new
versioncommand to theprotobuildCLI. This command provides detailed build information, including the project name, application version, and Git commit ID. - Build Process Enhancement: The
.goreleaser.yamlconfiguration has been updated to embed comprehensive build metadata (version, project name, build time, and commit ID) directly into the compiled binary usingldflags. This leverages a sharedgithub.com/pubgo/funk/versionpackage for consistency. - Internal Versioning Simplification: The local
version/version.gofile has been significantly simplified. It no longer contains complex version validation logic or external dependencies, as the runtime version information is now dynamically injected vialdflagsand accessed through thegithub.com/pubgo/funk/runningpackage.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a version subcommand to display build and version information. It also refactors how version information is handled, moving to a centralized package. The ldflags in the GoReleaser configuration are misconfigured, which would cause the new command to fail in release builds. I've provided a critical suggestion to fix this. Additionally, I've suggested a small improvement to make the version output more comprehensive.
No description provided.