few tweaks for objects api #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additionally, added possibility to add suffix for |
parfeon
requested changes
Jul 29, 2024
core/pubnub_objects_api.c
Outdated
|
|
||
| // TODO: maybe it will be a good idea to add serialization at some point to this SDK | ||
| if (NULL != opts.data.custom) { | ||
| strcat(obj_buffer, "\"custom\":"); |
There was a problem hiding this comment.
@Xavrax I know that this operation maybe not used that often, but strcat will traverse destination each time to find the right spot to append another string. Should we use snprintf here and in other places (I can patch)?
Comment on lines
48
to
53
| set_opts.data.name = "\"my_name\""; | ||
| set_opts.data.external_id = "\"my_external_id\""; | ||
| set_opts.data.profile_url = "\"my_profile_url\""; | ||
| set_opts.data.email = "\"my_email\""; | ||
| set_opts.data.custom = "{\"key\":\"value\"}"; | ||
| set_opts.include = "\"custom\""; |
There was a problem hiding this comment.
@Xavrax these lines actually look like another point to the snprintf usage (not that comfy as strcat) and the user will need to pass only actual values and snprintf will do the rest of the formatting. custom field yeah, special one, but the rest of them are plain strings.
refactor: update demo application Remove some App Context configuration options JSON "stringify" (remove escaped double quotes).
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: added
filterandsortparameters to be closer to the other SDKs with object API.added
filterandsortparameters to be closer to the other SDKs with object API.feat: configurable
booltype.configurable
booltype.fix: missing features needed for grant token API in CMakeLIsts.txt
missing features needed for grant token API in CMakeLIsts.txt