Fix fetch errors handling
#444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue because of errors returned by `fetch` taken from `iframe` (to protect against monkey-patching by APM packages) was't handled as Error. feat(listener): `SubscriptionSet` listener will receive updates from new Subscription `SubscriptionSet` will re-add listener every time when `Subscription` or `SubscriptionSet` added to it - this will let receive updates from newly added subscribe capable objects.
parfeon
added
status: done
mohitpubnub
approved these changes
Mar 11, 2025
| return true; | ||
| } | ||
|
|
||
| return Object.prototype.toString.call(object) === '[object Error]'; |
Use access token (auth key) content instead of base64 encoded token to identify PubNub clients, which can be used for requests aggregation.
mohitpubnub
approved these changes
Mar 12, 2025
| * | ||
| * @returns Tuple with parsed access token and its stringified content hash string. | ||
| */ | ||
| private async stringifyAccessToken(tokenString: string): Promise<[PAM.Token | undefined, string | undefined]> { |
Contributor
Author
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
Contributor
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(fetch): fix fetch error handling
Fix issue because of errors returned by
fetchtaken fromiframe(to protect against monkey-patching by APM packages) was't handled as Error.feat(listener):
SubscriptionSetlistener will receive updates from new SubscriptionSubscriptionSetwill re-add listener every time whenSubscriptionorSubscriptionSetadded to it - this will let receive updates from newly added subscribe capable objects.refactor(shared-worker): change request aggregate by authKey
Use access token (auth key) content instead of base64 encoded token to identify PubNub clients,
which can be used for requests aggregation.