Skip to content

Removed unused PNMalformedResponseCategory #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Removed unused PNMalformedResponseCategory #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pubnub-kotlin/pubnub-kotlin-api/config/ktlint/baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
<error line="1455" column="9" source="standard:property-naming" />
<error line="1456" column="9" source="standard:property-naming" />
<error line="1457" column="9" source="standard:property-naming" />
<error line="1460" column="9" source="standard:property-naming" />
<error line="1461" column="9" source="standard:property-naming" />
<error line="1462" column="9" source="standard:property-naming" />
<error line="1463" column="9" source="standard:property-naming" />
Expand Down
3 changes: 0 additions & 3 deletions pubnub-kotlin/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/kmp/factories.ios.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import cocoapods.PubNubSwift.KMPConnectionStatusCategoryDisconnected
import cocoapods.PubNubSwift.KMPConnectionStatusCategoryDisconnectedUnexpectedly
import cocoapods.PubNubSwift.KMPConnectionStatusCategoryHeartbeatFailed
import cocoapods.PubNubSwift.KMPConnectionStatusCategoryHeartbeatSuccess
import cocoapods.PubNubSwift.KMPConnectionStatusCategoryMalformedResponseCategory
import cocoapods.PubNubSwift.KMPConnectionStatusCategorySubscriptionChanged
import cocoapods.PubNubSwift.KMPEventListener
import cocoapods.PubNubSwift.KMPFileChangeEvent
Expand Down Expand Up @@ -347,8 +346,6 @@ actual fun createStatusListener(
PNStatusCategory.PNUnexpectedDisconnectCategory
KMPConnectionStatusCategoryConnectionError ->
PNStatusCategory.PNConnectionError
KMPConnectionStatusCategoryMalformedResponseCategory ->
PNStatusCategory.PNMalformedResponseCategory
KMPConnectionStatusCategoryHeartbeatFailed ->
PNStatusCategory.PNHeartbeatFailed
KMPConnectionStatusCategoryHeartbeatSuccess ->
Expand Down
1 change: 0 additions & 1 deletion pubnub-kotlin/pubnub-kotlin-api/src/jsMain/kotlin/Pubnub.d.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,7 +1452,6 @@ external interface Categories {
var PNReconnectedCategory: String
var PNConnectedCategory: String
var PNRequestMessageCountExceedCategory: String
var PNMalformedResponseCategory: String
var PNDisconnectedUnexpectedlyCategory: String
var PNConnectionErrorCategory: String
}
Expand Down
8 changes: 0 additions & 8 deletions ...lin/pubnub-kotlin-core-api/src/commonMain/kotlin/com/pubnub/api/enums/PNStatusCategory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,4 @@ enum class PNStatusCategory {
* A background implicit Heartbeat request was successful.
*/
PNHeartbeatSuccess,

/**
* PubNub sent a malformed response.
* This may happen when you connect to a public WiFi Hotspot that requires you to auth via your web browser first,
* or if there is a proxy somewhere returning an HTML access denied error,
* or if there was an intermittent server issue.
*/
PNMalformedResponseCategory,
}
1 change: 0 additions & 1 deletion ...src/test/kotlin/com/pubnub/internal/suite/history/v3/FetchMessagesMetaActionsTestSuite.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ class FetchMessagesMetaActionsTestSuite :
pnError = PubNubError.PARSING_ERROR
additionalChecks = { result ->
assertTrue(result.isFailure)
// assertEquals(PNStatusCategory.PNMalformedResponseCategory, status.category)
}
},
)
Expand Down
1 change: 0 additions & 1 deletion ...otlin-impl/src/test/kotlin/com/pubnub/internal/suite/history/v3/FetchMessagesTestSuite.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ class FetchMessagesTestSuite : com.pubnub.internal.suite.CoreEndpointTestSuite<F
pnError = PubNubError.PARSING_ERROR
additionalChecks = { result ->
assertTrue(result.isFailure)
// assertEquals(PNStatusCategory.PNMalformedResponseCategory, status.category)
}
},
)
Expand Down
Loading