Skip to content

Fix change log entry in .pubnub.yml #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix change log entry in .pubnub.yml #110

merged 1 commit into from
Jul 5, 2022

Conversation

@parfeon
Copy link
Contributor

@parfeon parfeon commented Jul 5, 2022

docs: fix change log

Fix malformed change log entry in .pubnub.yml.

@parfeon
docs: fix change log
f311cd5 
Fix malformed change log entry in `.pubnub.yml`.
@parfeon parfeon self-assigned this Jul 5, 2022
@parfeon parfeon added priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: documentation This PR contains updates to the documentation in code, README or .pubnub.yml. labels Jul 5, 2022
@parfeon
Copy link
Contributor Author

parfeon commented Jul 5, 2022 •
edited
Loading

Found bug with change log processing.. don't use : in line with change type. It can be used only in body of change entry.

This can be merged w/o release creation.

@parfeon parfeon merged commit 98efba0 into master Jul 5, 2022
@parfeon parfeon deleted the docs/fix/malformed-entry-yml branch July 5, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jguz-pubnub jguz-pubnub Awaiting requested review from jguz-pubnub jguz-pubnub is a code owner

1 more reviewer

@CraigLn CraigLn CraigLn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@parfeon parfeon

Labels

priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: documentation This PR contains updates to the documentation in code, README or .pubnub.yml.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parfeon @CraigLn