Fix for Issue#129 and Issue#173 by fixing a threading issue with the original implementation. #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a LockIsolated helper that will avoid threading related crashes.
cmriboldi
requested review from
jguz-pubnub,
marcin-cebo,
parfeon and
wkal-pubnub
as code owners
jguz-pubnub
reviewed
Sep 10, 2024
|
|
||
| /// A generic wrapper for isolating a mutable value with a lock. | ||
| @dynamicMemberLookup | ||
| public final class LockIsolated<Value>: @unchecked Sendable { |
Contributor
There was a problem hiding this comment.
@cmriboldi is there a particular reason why this class is public?
Author
There was a problem hiding this comment.
No it doesn't need to be public.
|
@cmriboldi this issue is addressed in 7.3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LockIsolated is a helper that will help avoid threading related crashes by ensuring the value is only referenced or edited by a single source at a time. There where two main crashes that were resulting from threading issues in the WeakBox and SubscriptionSession implementations. This light weight fix should avoid those threading issues in the future.