Add support for the type field in PubNubMembershipMetadata
#194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
requested review from
marcin-cebo,
parfeon and
wkal-pubnub
as code owners
parfeon
reviewed
Nov 26, 2024
Contributor
parfeon
left a comment
parfeon
left a comment
There was a problem hiding this comment.
Mostly looks good! :)
Just a few questions.
* Deprecate PubNub.IncludeFields and introduce PubNub.UserIncludeFields and PubNub.ChannelIncludeFields * Replace ObjectsUUIDRouter with ObjectsUserRouter * Replace other occurences of UUID with User in AppContext related code * Other minor fixes * Introduce new method for removing Channel metadata * Fixes for acceptance tests
jguz-pubnub
force-pushed
the
feat/membership-type
branch
from
ca74368 to
3e292cf
Compare
Contributor
Author
|
@pubnub-release-bot release |
jguz-pubnub
changed the title
jguz-pubnub
changed the title
jguz-pubnub
changed the title
type field in PubNubMembershipMetadata
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(membership): add support for the
typefield inPubNubMembershipMetadatafeat(app-context): deprecate methods containing
uuidparameter, introduce new versionsfeat(app-context): deprecate methods containing
includeparameter ofBooltype, introduce new versionsfeat(app-context): deprecate
remove(channel:custom:completion:), introduce new versionfeat(app-context): replace
PubNubUUIDMetadatawithPubNubUserMetadatafeat(app-context): replace
PubNubUUIDMetadataBasewithPubNubUserMetadataBasefeat(app-context): add an alias for backward compatibility with the customer code using
PubNubUUIDMetadatafeat(app-context): add an alias for backward compatibility with the customer code using
PubNubUUIDMetadataBasefeat(listeners): replace
PubNubUUIDMetadataChangesetwithPubNubUserMetadataChangesetfeat(listeners): add an alias for backward compatibility with the customer code using
PubNubUUIDMetadataChangeset