Some minor fixes #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want restart clock but it is yet mounted it did't work.
pughpugh
added a commit
that referenced
this pull request
May 19, 2015
Some minor fixes via @dvilchez
Owner
|
Ta, thanks @dvilchez |
Owner
There was a problem hiding this comment.
I notice the demo page now accelerates after each iteration.
In hindsight I'm not sure this works. _setScale needs to be called after the setState seconds: props.seconds has been called. Even if you move the ordering around, I think the asynchronous nature of setState still messes this up.
Contributor
Author
|
I can't notice it, but after reviewing the code I think it would be more simple if it wouldn't set the state due to the fact that it doesn't need that render method was called to redraw the canvas. |
Owner
|
Do you mean - why set state if it's not intended to recall render? If so, I think I agree. |
Contributor
Author
|
Yes, That's it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using it in my project and I have to make some fixes to get it work properly.