Simple new website cleanup #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meadowsys
approved these changes
Sep 1, 2025
Member
meadowsys
left a comment
meadowsys
left a comment
There was a problem hiding this comment.
from a quick scan through the diffs, everything looks in order,
layouts/home.ejs
Outdated
| <a href="https://tutanota.com/" target="_blank"> | ||
| <img src="/static/tutanota-logo.webp" alt="tutanota.com" class="sponsors__logo"> | ||
| <a href="https://tuta.com/" target="_blank"> | ||
| <img src="/static/tuta_logo.svg" alt="tuta.com" class="sponsors__logo"> |
Contributor
There was a problem hiding this comment.
We might want to specify an explicit width here, since SVGs don't have intrinsic width or height. Let me check it locally to see how it looks.
Contributor
There was a problem hiding this comment.
Yeah, it's huge. Give me a minute to fix this.
savetheclocktower
previously requested changes
Sep 1, 2025
Contributor
savetheclocktower
left a comment
savetheclocktower
left a comment
There was a problem hiding this comment.
Leaving a placeholder review while I fix the SVG size.
Member
Author
|
Good catch on the size issue @savetheclocktower I'd say lets go with your modified version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some missed items in the new site deployment